Skip to content

feat(tui): add prefix-filtered prompt history navigation #9021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
avillagran wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat(tui): add prefix-filtered prompt history navigation #9021

avillagran wants to merge 1 commit into from
+273 −12

Conversation

@avillagran
Copy link

@avillagran avillagran commented Jan 17, 2026

  • Implement filtered history navigation (Ctrl/Cmd + Up/Down) in the prompt input
  • Preserve normal history behavior when not filtering
  • Add a lightweight, runtime-free test helper for prompt history to avoid importing Solid in unit tests
  • Update history store to delegate test factory to the helper
  • Add unit tests for history navigation

@avillagran
feat(tui): add prefix-filtered prompt history navigation and test hel…
2c924ba 
…per\n\n- Implement filtered history navigation (Ctrl/Cmd + Up/Down) in the prompt input\n- Preserve normal history behavior when not filtering\n- Add a lightweight, runtime-free test helper for prompt history to avoid importing Solid in unit tests\n- Update history store to delegate test factory to the helper\n- Add unit tests for history navigation (test-only helper)\n- Remove stray debug/log calls introduced during development\nRationale: keeps unit tests fast and framework-independent, improves UX by enabling prefix-based history search while retaining backward compatibility with existing navigation.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2026

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2026

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate PRs Found:

  1. PR Fix ctrl+p/ctrl+n navigation in multi-line TUI prompts #5473: "Fix ctrl+p/ctrl+n navigation in multi-line TUI prompts"

  2. PR feat(tui): add inline Ctrl+R reverse-i-search for prompt history #6276: "feat(tui): add inline Ctrl+R reverse-i-search for prompt history"

  3. PR fix(tui): resolve keybind conflicts and missing defaults (issue #4997) #8786: "fix(tui): resolve keybind conflicts and missing defaults (issue Keybinds #4997)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs:issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@avillagran